modernize elapsed time composable - #539
Open
Kimblebee wants to merge 9 commits into
Open
Conversation
Kimblebee
commented
Jul 13, 2026
Kimblebee
commented
Collaborator
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the ElapsedTimeText component to wrap the elapsed time in a styled red background box and adds a preview function for it. It also adds the androidx-foundation-layout dependency. The review feedback suggests optimizing performance by using derivedStateOf to defer reading the high-frequency elapsed time state, and cleaning up outdated parameter documentation in the KDoc of ElapsedTimeText.
- Update ElapsedTimeUiState.Enabled to include an isPaused flag. - Update ElapsedTimeUiStateAdapter to map VideoRecordingState.Active.Paused to the new paused UI state. - Extract hardcoded video duration format strings to strings.xml. - Implement paused text display and optimize remember key in ElapsedTimeText. - Add explicit foundation-layout dependency in ui:debug module. - Add unit tests for ElapsedTimeUiStateAdapter and component tests for ElapsedTimeText. - Fix constructor call compilation in CameraXCameraSystemTest.
- Set custom content descriptions for active and paused recording states to improve TalkBack announcements.
- Add decoupled tests to verify text and accessibility properties in CaptureScreenComponentsTest.
- Integrate ATF contrast checks in UI test rendering scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.